8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

[shipilev]

Fixes the JDK 21 regression. Simple fix.

Additional testing:

• MacOS AArch64 server fastdebug, jdk/jshell passes

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8328703 needs maintainer approval

Issue

• JDK-8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/172/head:pull/172
$ git checkout pull/172

Update a local copy of the PR:
$ git checkout pull/172
$ git pull https://git.openjdk.org/jdk22u.git pull/172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 172

View PR using the GUI difftool:
$ git pr show -t 172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/172.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 72d3f61: 8326974: ODR violation in macroAssembler_aarch64.cpp
• bb313b5: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
• 437d655: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
• b2fbc82: 8322962: Upcall stub might go undetected when freezing frames
• f08201c: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• e6ba0ee: 8325179: Race in BasicDirectoryModel.validateFileCache
• 7381b84: 8320692: Null icon returned for .exe without custom icon
• 5eb11e5: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
• 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[shipilev]

/approval request Fixes the JDK 21 regression. Applies cleanly, simple fix. There are no regression tests, but the jshell tests (AFAICS, the largest jline user) pass. Risk is low: fixes a simple problem with a simple patch.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@shipilev
8328703: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (006fdda5)

[shipilev]

/integrate

[openjdk]

Going to push as commit d2e1ea4.
Since your change was applied there have been 10 commits pushed to the master branch:

• 72d3f61: 8326974: ODR violation in macroAssembler_aarch64.cpp
• bb313b5: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
• 437d655: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
• b2fbc82: 8322962: Upcall stub might go undetected when freezing frames
• f08201c: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• e6ba0ee: 8325179: Race in BasicDirectoryModel.validateFileCache
• 7381b84: 8320692: Null icon returned for .exe without custom icon
• 5eb11e5: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
• 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit d2e1ea4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.