Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331142: Add test for number of loader threads in BasicDirectoryModel #175

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented May 1, 2024

Provides a regression test for JDK-8325179: Race in BasicDirectoryModel.validateFileCache which is backported to 22u.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8331495 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331142 needs maintainer approval

Issues

  • JDK-8331142: Add test for number of loader threads in BasicDirectoryModel (Bug - P4 - Approved)
  • JDK-8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only (Sub-task - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/175/head:pull/175
$ git checkout pull/175

Update a local copy of the PR:
$ git checkout pull/175
$ git pull https://git.openjdk.org/jdk22u.git pull/175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 175

View PR using the GUI difftool:
$ git pr show -t 175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/175.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331142: Add test for number of loader threads in BasicDirectoryModel
8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • beb06e1: 8330094: RISC-V: Save and restore FRM in the call stub
  • 5c15483: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • e96e6ab: 8329850: [AIX] Allow loading of different members of same shared library archive
  • d2e1ea4: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b2fb5ea13ba5087411410519213fc953ecc44618 8331142: Add test for number of loader threads in BasicDirectoryModel May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 1, 2024
@mlbridge
Copy link

mlbridge bot commented May 1, 2024

Webrevs

@openjdk openjdk bot removed the clean label May 1, 2024
@aivanov-jdk
Copy link
Member Author

/issue add 8331495

@openjdk
Copy link

openjdk bot commented May 1, 2024

@aivanov-jdk
Adding additional issue to issue list: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 7, 2024
@aivanov-jdk
Copy link
Member Author

The test proved to be unstable on Windows too, the test is modified by JDK-8331999.

It is safer not to integrate this PR to avoid bringing new test failures.

If deemed necessary, the PR could updated with JDK-8331999.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants