Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8330815: Use pattern matching for instanceof in KeepAliveCache #178

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 1, 2024

Hi all,

This pull request contains a backport of JDK-8330815, commit e818ab60 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 25 Apr 2024 and was reviewed by Jaikiran Pai and Daniel Jeliński.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330815 needs maintainer approval

Issue

  • JDK-8330815: Use pattern matching for instanceof in KeepAliveCache (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/178/head:pull/178
$ git checkout pull/178

Update a local copy of the PR:
$ git checkout pull/178
$ git pull https://git.openjdk.org/jdk22u.git pull/178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 178

View PR using the GUI difftool:
$ git pr show -t 178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/178.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330815: Use pattern matching for instanceof in KeepAliveCache

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • beb06e1: 8330094: RISC-V: Save and restore FRM in the call stub
  • 5c15483: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • e96e6ab: 8329850: [AIX] Allow loading of different members of same shared library archive
  • d2e1ea4: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e818ab60a0c1dac277b8b15301cdfb7d439ed26c 8330815: Use pattern matching for instanceof in KeepAliveCache May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 1, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2024
@mlbridge
Copy link

mlbridge bot commented May 1, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 2, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2024

Going to push as commit 0ec3c0b.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e4a1a7b: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier
  • f3f8176: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • e77a047: 8328822: C2: "negative trip count?" assert failure in profile predicate code
  • beb06e1: 8330094: RISC-V: Save and restore FRM in the call stub
  • 5c15483: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • e96e6ab: 8329850: [AIX] Allow loading of different members of same shared library archive
  • d2e1ea4: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2024
@openjdk openjdk bot closed this May 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@RealCLanger Pushed as commit 0ec3c0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant