Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier #182

Closed
wants to merge 1 commit into from

Conversation

johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented May 3, 2024

clean backport of openjdk/jdk@819f3d6


Progress

  • Change must not contain extraneous whitespace
  • JDK-8330748 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.org/jdk22u.git pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/182.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2024

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 3, 2024

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier

Reviewed-by: bpb, coffeys, jpai
Backport-of: 819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • f3f8176: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • e77a047: 8328822: C2: "negative trip count?" assert failure in profile predicate code
  • beb06e1: 8330094: RISC-V: Save and restore FRM in the call stub
  • 5c15483: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • e96e6ab: 8329850: [AIX] Allow loading of different members of same shared library archive

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 3, 2024
@mlbridge
Copy link

mlbridge bot commented May 3, 2024

Webrevs

@johnyjose30
Copy link
Contributor Author

/reviewer credit @coffeys @jaikiran

@openjdk
Copy link

openjdk bot commented May 3, 2024

@johnyjose30
Reviewer coffeys successfully credited.

Reviewer jpai successfully credited.

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the original

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 7, 2024
@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@johnyjose30
Your change (at version 7825701) is now ready to be sponsored by a Committer.

@robm-openjdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 7, 2024

Going to push as commit e4a1a7b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • f3f8176: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • e77a047: 8328822: C2: "negative trip count?" assert failure in profile predicate code
  • beb06e1: 8330094: RISC-V: Save and restore FRM in the call stub
  • 5c15483: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • e96e6ab: 8329850: [AIX] Allow loading of different members of same shared library archive

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2024
@openjdk openjdk bot closed this May 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@robm-openjdk @johnyjose30 Pushed as commit e4a1a7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants