Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8322726: C2: Unloaded signature class kills argument value #187

Closed
wants to merge 1 commit into from

Conversation

fmatte1
Copy link

@fmatte1 fmatte1 commented May 7, 2024

8322726: C2: Unloaded signature class kills argument value
Reviewed-by: kvn, dlong, thartmann


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322726 needs maintainer approval

Issue

  • JDK-8322726: C2: Unloaded signature class kills argument value (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/187/head:pull/187
$ git checkout pull/187

Update a local copy of the PR:
$ git checkout pull/187
$ git pull https://git.openjdk.org/jdk22u.git pull/187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 187

View PR using the GUI difftool:
$ git pr show -t 187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/187.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322726: C2: Unloaded signature class kills argument value

Reviewed-by: vlivanov, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • fc18e8a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 7b1ae12: 8325621: Improve jspawnhelper version checks
  • 8eac95e: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • 0ec3c0b: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • e4a1a7b: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier
  • f3f8176: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • e77a047: 8328822: C2: "negative trip count?" assert failure in profile predicate code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport fa02667d838f08cac7d41dfb4c3e8056ae6165cc 8322726: C2: Unloaded signature class kills argument value May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 7, 2024

⚠️ @fmatte1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@fmatte1
Copy link
Author

fmatte1 commented May 7, 2024

/approval

@openjdk
Copy link

openjdk bot commented May 7, 2024

@fmatte1 usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 9, 2024
@fmatte1
Copy link
Author

fmatte1 commented May 13, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@fmatte1
Your change (at version 1cba224) is now ready to be sponsored by a Committer.

@chhagedorn
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit 7629aa6.
Since your change was applied there have been 7 commits pushed to the master branch:

  • fc18e8a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 7b1ae12: 8325621: Improve jspawnhelper version checks
  • 8eac95e: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • 0ec3c0b: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • e4a1a7b: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier
  • f3f8176: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • e77a047: 8328822: C2: "negative trip count?" assert failure in profile predicate code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@chhagedorn @fmatte1 Pushed as commit 7629aa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants