Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8325255: jdk.internal.util.ReferencedKeySet::add using wrong test #189

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 8, 2024

Clean backport to fix a corner case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325255 needs maintainer approval

Issue

  • JDK-8325255: jdk.internal.util.ReferencedKeySet::add using wrong test (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/189/head:pull/189
$ git checkout pull/189

Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk22u.git pull/189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 189

View PR using the GUI difftool:
$ git pr show -t 189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/189.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

shipilev commented May 8, 2024

/approval request Follow up for recent JDK-8310913 integration. Applies cleanly, regression test is sensitive to the bug. Nothing else is using the affected method in JDK 21, so risk is low.

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 8, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325255: jdk.internal.util.ReferencedKeySet::add using wrong test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fc18e8a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 7b1ae12: 8325621: Improve jspawnhelper version checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a7461de231da20ed78a7c6ad8275f1bafbfa556c 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 8, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@shipilev
8325255: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 8, 2024
@mlbridge
Copy link

mlbridge bot commented May 8, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 10, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit 2cb2e6b.
Since your change was applied there have been 9 commits pushed to the master branch:

  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 61792bc: 8331344: No compiler replay file with CompilerCommand MemLimit
  • 9b3187f: 8330027: Identity hashes of archived objects must be based on a reproducible random seed
  • 9486b7c: 8324243: Compilation failures in java.desktop module with gcc 14
  • 2ec7dbf: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • ccef462: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 7629aa6: 8322726: C2: Unloaded signature class kills argument value
  • fc18e8a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 7b1ae12: 8325621: Improve jspawnhelper version checks

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@shipilev Pushed as commit 2cb2e6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant