-
Notifications
You must be signed in to change notification settings - Fork 57
8325255: jdk.internal.util.ReferencedKeySet::add using wrong test #189
Conversation
/approval request Follow up for recent JDK-8310913 integration. Applies cleanly, regression test is sensitive to the bug. Nothing else is using the affected method in JDK 21, so risk is low. |
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit 2cb2e6b.
Your commit was automatically rebased without conflicts. |
Clean backport to fix a corner case.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/189/head:pull/189
$ git checkout pull/189
Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk22u.git pull/189/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 189
View PR using the GUI difftool:
$ git pr show -t 189
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/189.diff
Webrev
Link to Webrev Comment