8325587: Shenandoah: ShenandoahLock should allow blocking in VM

[mmyxym]

Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325587 needs maintainer approval

Issue

• JDK-8325587: Shenandoah: ShenandoahLock should allow blocking in VM (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/192/head:pull/192
$ git checkout pull/192

Update a local copy of the PR:
$ git checkout pull/192
$ git pull https://git.openjdk.org/jdk22u.git pull/192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 192

View PR using the GUI difftool:
$ git pr show -t 192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/192.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325587: Shenandoah: ShenandoahLock should allow blocking in VM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• b0cd610: 8332253: Linux arm32 build fails after 8292591
• 4541823: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
• f539469: 8330464: hserr generic events - add entry for the before_exit calls
• da980f9: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
• 1e173f9: 8330814: Cleanups for KeepAliveCache tests
• 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• fdb8491: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
• 01d0fda: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
• 6e66ee1: 8331298: avoid alignment checks in UBSAN enabled build
• 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• ... and 16 more: https://git.openjdk.org/jdk22u/compare/fc18e8a8c2ffc2108783e8b325fe2c9a6f51cdfa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mmyxym]

/approval request Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. Risk is quite low.

[openjdk]

@mmyxym
8325587: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (0f85a625)

[RealCLanger]

@mmyxym would you mind integrating this to proceed with further backports?

[mmyxym]

@shipilev ，shall I integrate this into 22u?

[shipilev]

Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger?

[RealCLanger]

Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger?

I can see that a backport to 21u is already requested - so I wanted to see this in 22u first.

[mmyxym]

Sure I can do the further related backports. Are JDK-8331405 and JDK-8331411 sufficient? @shipilev

[shipilev]

Sure I can do the further related backports. Are JDK-8331405 and JDK-8331411 sufficient? @shipilev

We caught a little regression with JDK-8331405 today, investigating. This is why I think we need to wait a bit with 21u backports. This particular one for 22u is fine, but not others.

[mmyxym]

/integrate

[openjdk]

@mmyxym
Your change (at version 0f85a62) is now ready to be sponsored by a Committer.

[mmyxym]

Could committers please help to sponsor?

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit ae8dae9.
Since your change was applied there have been 26 commits pushed to the master branch:

• b0cd610: 8332253: Linux arm32 build fails after 8292591
• 4541823: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
• f539469: 8330464: hserr generic events - add entry for the before_exit calls
• da980f9: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
• 1e173f9: 8330814: Cleanups for KeepAliveCache tests
• 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• fdb8491: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
• 01d0fda: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
• 6e66ee1: 8331298: avoid alignment checks in UBSAN enabled build
• 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• ... and 16 more: https://git.openjdk.org/jdk22u/compare/fc18e8a8c2ffc2108783e8b325fe2c9a6f51cdfa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @mmyxym Pushed as commit ae8dae9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.