Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8329862: libjli GetApplicationHome cleanups and enhance jli tracing #195

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 10, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8329862 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8329862: libjli GetApplicationHome cleanups and enhance jli tracing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/195/head:pull/195
$ git checkout pull/195

Update a local copy of the PR:
$ git checkout pull/195
$ git pull https://git.openjdk.org/jdk22u.git pull/195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 195

View PR using the GUI difftool:
$ git pr show -t 195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/195.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329862: libjli GetApplicationHome cleanups and enhance jli tracing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 377f2e538ae0fc94fc5483700a3ae70175017741 8329862: libjli GetApplicationHome cleanups and enhance jli tracing May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 10, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 10, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit c3e9084.
Since your change was applied there have been 11 commits pushed to the master branch:

  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • dd5581c: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 2cb2e6b: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 61792bc: 8331344: No compiler replay file with CompilerCommand MemLimit
  • 9b3187f: 8330027: Identity hashes of archived objects must be based on a reproducible random seed
  • 9486b7c: 8324243: Compilation failures in java.desktop module with gcc 14
  • 2ec7dbf: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • ccef462: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • ... and 1 more: https://git.openjdk.org/jdk22u/compare/fc18e8a8c2ffc2108783e8b325fe2c9a6f51cdfa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@MBaesken Pushed as commit c3e9084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant