Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331352: error: template-id not allowed for constructor/destructor in C++20 #198

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented May 12, 2024

It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64).
It needs all of JDK-8328997 (backport), JDK-8331352 (this backport) and JDK-8324243 (backport).
Git cherry-pick was clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331352 needs maintainer approval

Issue

  • JDK-8331352: error: template-id not allowed for constructor/destructor in C++20 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/198/head:pull/198
$ git checkout pull/198

Update a local copy of the PR:
$ git checkout pull/198
$ git pull https://git.openjdk.org/jdk22u.git pull/198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 198

View PR using the GUI difftool:
$ git pr show -t 198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/198.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331352: error: template-id not allowed for constructor/destructor in C++20

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7629aa6: 8322726: C2: Unloaded signature class kills argument value

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 45792c5829fb1d5ee016c4a1fd6badb5d2b4239c 8331352: error: template-id not allowed for constructor/destructor in C++20 May 12, 2024
@openjdk
Copy link

openjdk bot commented May 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 12, 2024

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented May 12, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 13, 2024
@jankratochvil
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@jankratochvil
Your change (at version df434aa) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit 2ec7dbf.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ccef462: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 7629aa6: 8322726: C2: Unloaded signature class kills argument value

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr @jankratochvil Pushed as commit 2ec7dbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants