-
Notifications
You must be signed in to change notification settings - Fork 60
8324243: Compilation failures in java.desktop module with gcc 14 #199
Conversation
Reviewed-by: jwaters, ihse, kbarrett, prr
|
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
|
@jankratochvil This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/integrate |
|
@jankratochvil |
|
/sponsor |
|
Going to push as commit 9486b7c.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr @jankratochvil Pushed as commit 9486b7c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64).
It needs all of JDK-8328997 (backport), JDK-8331352 (backport) and JDK-8324243 (this backport).
Git cherry-pick was clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/199/head:pull/199$ git checkout pull/199Update a local copy of the PR:
$ git checkout pull/199$ git pull https://git.openjdk.org/jdk22u.git pull/199/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 199View PR using the GUI difftool:
$ git pr show -t 199Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/199.diff
Webrev
Link to Webrev Comment