Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8321480: ISO 4217 Amendment 176 Update #2

Closed
wants to merge 1 commit into from
Closed

8321480: ISO 4217 Amendment 176 Update #2

wants to merge 1 commit into from

Conversation

weibxiao
Copy link
Contributor

@weibxiao weibxiao commented Dec 15, 2023 •
edited by openjdk bot
Loading

FIX REQUEST

It is ISO 4217 Amendment 176 Update. It is a mandatory change.

The patch was applied cleanly. It has a minimum risk to push this to the release.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321480 needs maintainer approval

Issue

  • JDK-8321480: ISO 4217 Amendment 176 Update (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/jdk22u.git pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/2.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2023

👋 Welcome back weibxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b24851b9d3619c41c7a6cdb9193ed26a9b732dc 8321480: ISO 4217 Amendment 176 Update Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

⚠️ @weibxiao This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 15, 2023
@weibxiao
Copy link
Contributor Author

weibxiao commented Jan 3, 2024

/approval

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@weibxiao usage: /approval [<id>] (request|cancel) [<text>]

@weibxiao
Copy link
Contributor Author

weibxiao commented Jan 3, 2024

/approval request ISO 4217 Amendment 176 Update

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@weibxiao
8321480: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024 •
edited
Loading

@weibxiao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321480: ISO 4217 Amendment 176 Update

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • bb0e203: 8321582: yield .class not parsed correctly.
  • ... and 22 more: https://git.openjdk.org/jdk22u/compare/84d716a2671845058770ee03c97497d7a711fa92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 8, 2024
@weibxiao
Copy link
Contributor Author

weibxiao commented Jan 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@weibxiao
Your change (at version 677d40b) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 9, 2024
@coffeys
Copy link
Contributor

coffeys commented Jan 9, 2024

/sponsor

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 9e1e6e1.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • bb0e203: 8321582: yield .class not parsed correctly.
  • ... and 22 more: https://git.openjdk.org/jdk22u/compare/84d716a2671845058770ee03c97497d7a711fa92...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@coffeys @weibxiao Pushed as commit 9e1e6e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

battleblow added a commit to battleblow/jdk22u that referenced this pull request Mar 24, 2024
@battleblow
Working extended file attributes for BSD (openjdk#2)
6283948 
* Add code that handles the BSD extended file attribute semantics.
  This allows them to work correctly on FreeBSD.
* Make the Linux semantics the default to avoid changing the Linux
  code.  Ideally we'd be explicit everywhere instead, but this likely
  makes merges simpler.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weibxiao @coffeys