Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx #200

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 13, 2024

Clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329223 needs maintainer approval

Issue

  • JDK-8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jdk22u.git pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/200.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • c3e9084: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • dd5581c: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 2cb2e6b: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 61792bc: 8331344: No compiler replay file with CompilerCommand MemLimit
  • 9b3187f: 8330027: Identity hashes of archived objects must be based on a reproducible random seed
  • ... and 3 more: https://git.openjdk.org/jdk22u/compare/7629aa6301f1c9f3757559d14e7110d7fddb4a3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport aca1e8365bf0f64bf18caf798bbca1d25b3c4117 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @zhengyu123 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 13, 2024
@zhengyu123
Copy link
Contributor Author

/integrate

Approved

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit 9e3344e.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 5177264: 8316138: Add GlobalSign 2 TLS root certificates
  • f1eba2c: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095
  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • c3e9084: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • dd5581c: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 2cb2e6b: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • ... and 5 more: https://git.openjdk.org/jdk22u/compare/7629aa6301f1c9f3757559d14e7110d7fddb4a3d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@zhengyu123 Pushed as commit 9e3344e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant