Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all #202

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 14, 2024

Hi all,
This is clean backport of JDK-8331466. Only change the Problemlist.txt, the risk is low.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331466 needs maintainer approval

Issue

  • JDK-8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/202/head:pull/202
$ git checkout pull/202

Update a local copy of the PR:
$ git checkout pull/202
$ git pull https://git.openjdk.org/jdk22u.git pull/202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 202

View PR using the GUI difftool:
$ git pr show -t 202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/202.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • c3e9084: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • dd5581c: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 2cb2e6b: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 440782e0160f867f08afbec0abf48d557a522c72 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 14, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@sendaoYan
Copy link
Member Author

/approval request This is clean backport of JDK-8331466. Only change the Problemlist.txt, the risk is low.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@sendaoYan
8331466: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 16, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented May 16, 2024

The GHA test runner report a windows-x64 jtreg known failure java/util/zip/ZipFile/ZipSourceCache.java, which has been recored in JDK-8322078. The failure is unrelated to this PR. I have been created a backport to fix this issue.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@sendaoYan
Your change (at version a560446) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit fdb8491.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 01d0fda: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
  • 6e66ee1: 8331298: avoid alignment checks in UBSAN enabled build
  • 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • 5177264: 8316138: Add GlobalSign 2 TLS root certificates
  • f1eba2c: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095
  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • c3e9084: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • ... and 3 more: https://git.openjdk.org/jdk22u/compare/61792bc2297444df79adef78a1e3bcafaf61e305...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@shipilev @sendaoYan Pushed as commit fdb8491.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants