Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331298: avoid alignment checks in UBSAN enabled build #204

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 14, 2024


Progress

  • JDK-8331298 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331298: avoid alignment checks in UBSAN enabled build (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk22u.git pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/204.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331298: avoid alignment checks in UBSAN enabled build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 60b61e588c1252b4b1fbc64d0f818a85670f7146 8331298: avoid alignment checks in UBSAN enabled build May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 16, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit 6e66ee1.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • 5177264: 8316138: Add GlobalSign 2 TLS root certificates
  • f1eba2c: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095
  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version
  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@MBaesken Pushed as commit 6e66ee1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant