Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghmaimon
Copy link

@ghmaimon ghmaimon commented May 15, 2024

Reviewed-by: tschatzl, ayang


Progress

  • Change must not contain extraneous whitespace
  • JDK-8299023 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.org/jdk22u.git pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/208.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

Hi @ghmaimon, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ghmaimon" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2024

@ghmaimon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • c68a285: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)
  • 5602dc7: 8330176: Typo in Linker javadoc
  • 2b25595: 8326112: Javadoc snippet for Linker.Option.captureCallState is wrong
  • e1b620e: 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1
  • 1f73c98: 8329134: Reconsider TLAB zapping
  • 92e4ba2: 8331885: C2: meet between unloaded and speculative types is not symmetric
  • 108e164: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • 329c7bd: 8325763: Revert properties: vm.opt.x.*
  • 0080e66: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • ceba7fc: 8330275: Crash in XMark::follow_array
  • ... and 27 more: https://git.openjdk.org/jdk22u/compare/0f3b3fa4a073b13140154cd577268aec9218c143...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f50df105912858198809b50432ef5a4ab184528d 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

This backport pull request has now been updated with issue from the original commit.

@ghmaimon
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label May 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot removed the approval label May 16, 2024
@ghmaimon
Copy link
Author

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

⚠️ @ghmaimon the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8299023
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2024

@ghmaimon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants