-
Notifications
You must be signed in to change notification settings - Fork 57
8318158: RISC-V: implement roundD/roundF intrinsics #21
8318158: RISC-V: implement roundD/roundF intrinsics #21
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
/approval request Clean backport, related only to RISC-V platform, to optimize performance in double/float rounding operations via intrinsics. |
@omikhaltsova |
@omikhaltsova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8ff288f.
Your commit was automatically rebased without conflicts. |
@omikhaltsova Pushed as commit 8ff288f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport JDK-8318158 to jdk22u in order to optimize performance in double/float rounding operations by means of intrinsics.
The patch applied cleanly.
Tested: no regression in tier1 tests.
The benchmark shows the following performance improvement on the T-Head RVB-ICE board:
Before
After
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/21/head:pull/21
$ git checkout pull/21
Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/jdk22u.git pull/21/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21
View PR using the GUI difftool:
$ git pr show -t 21
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/21.diff
Webrev
Link to Webrev Comment