Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332253: Linux arm32 build fails after 8292591 #210

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 16, 2024

Hi all,

This pull request contains a backport of commit 95f79c67 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 16 May 2024 and was reviewed by Thomas Stuefe, David Holmes and Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332253 needs maintainer approval

Issue

  • JDK-8332253: Linux arm32 build fails after 8292591 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.org/jdk22u.git pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/210.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332253: Linux arm32 build fails after 8292591

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 1e173f9: 8330814: Cleanups for KeepAliveCache tests
  • 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • fdb8491: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 01d0fda: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
  • 6e66ee1: 8331298: avoid alignment checks in UBSAN enabled build
  • 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • 5177264: 8316138: Add GlobalSign 2 TLS root certificates
  • f1eba2c: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095
  • f5ce46f: 8329961: Buffer overflow in os::Linux::kernel_version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 95f79c678737fb8de9ed45c516761d4d818869ef 8332253: Linux arm32 build fails after 8292591 May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 16, 2024 21:41
@openjdk
Copy link

openjdk bot commented May 16, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2024
@mlbridge
Copy link

mlbridge bot commented May 16, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 16, 2024
@mrserb
Copy link
Member Author

mrserb commented May 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2024

Going to push as commit b0cd610.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 4541823: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • f539469: 8330464: hserr generic events - add entry for the before_exit calls
  • da980f9: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 1e173f9: 8330814: Cleanups for KeepAliveCache tests
  • 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • fdb8491: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 01d0fda: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
  • 6e66ee1: 8331298: avoid alignment checks in UBSAN enabled build
  • 9e3344e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • 5177264: 8316138: Add GlobalSign 2 TLS root certificates
  • ... and 2 more: https://git.openjdk.org/jdk22u/compare/0f3b3fa4a073b13140154cd577268aec9218c143...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2024
@openjdk openjdk bot closed this May 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

@mrserb Pushed as commit b0cd610.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant