Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8329109: Threads::print_on() tries to print CPU time for terminated GC threads #215

Closed
wants to merge 1 commit into from

Conversation

mmyxym
Copy link

@mmyxym mmyxym commented May 20, 2024

Clean backport of fixing crash on Threads::print_on() .


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329109 needs maintainer approval

Issue

  • JDK-8329109: Threads::print_on() tries to print CPU time for terminated GC threads (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jdk22u.git pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/215.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2024

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329109: Threads::print_on() tries to print CPU time for terminated GC threads

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ae8dae9: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
  • b0cd610: 8332253: Linux arm32 build fails after 8292591
  • 4541823: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • f539469: 8330464: hserr generic events - add entry for the before_exit calls
  • da980f9: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 1e173f9: 8330814: Cleanups for KeepAliveCache tests
  • 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c1cfb43d8de8d0eed01b9bb6aa1202dc7cbff007 8329109: Threads::print_on() tries to print CPU time for terminated GC threads May 20, 2024
@openjdk
Copy link

openjdk bot commented May 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 20, 2024

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 20, 2024
@mlbridge
Copy link

mlbridge bot commented May 20, 2024

Webrevs

@mmyxym
Copy link
Author

mmyxym commented May 20, 2024

/approval request Clean backport of fixing crash on Threads::print_on() . Risk is very low.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@mmyxym
8329109: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 20, 2024
@mmyxym
Copy link
Author

mmyxym commented May 23, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@mmyxym
Your change (at version 156b6a8) is now ready to be sponsored by a Committer.

@mmyxym
Copy link
Author

mmyxym commented May 23, 2024

Could committers please help to sponsor?

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2024

Going to push as commit a3e51ec.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ae8dae9: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
  • b0cd610: 8332253: Linux arm32 build fails after 8292591
  • 4541823: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • f539469: 8330464: hserr generic events - add entry for the before_exit calls
  • da980f9: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 1e173f9: 8330814: Cleanups for KeepAliveCache tests
  • 9836209: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2024
@openjdk openjdk bot closed this May 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@RealCLanger @mmyxym Pushed as commit a3e51ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants