Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331746: Create a test to verify that the cmm id is not ignored #218

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 21, 2024

Hi all,

This pull request contains a backport of commit 7c750fd9 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331746 needs maintainer approval

Issue

  • JDK-8331746: Create a test to verify that the cmm id is not ignored (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/218/head:pull/218
$ git checkout pull/218

Update a local copy of the PR:
$ git checkout pull/218
$ git pull https://git.openjdk.org/jdk22u.git pull/218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 218

View PR using the GUI difftool:
$ git pr show -t 218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/218.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 21, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331746: Create a test to verify that the cmm id is not ignored

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5a659b7: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • e32e05b: 8329840: Fix ZPhysicalMemorySegment::_end type
  • a3e51ec: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • ae8dae9: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd 8331746: Create a test to verify that the cmm id is not ignored May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 22, 2024 00:23
@openjdk
Copy link

openjdk bot commented May 22, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels May 22, 2024
@mlbridge
Copy link

mlbridge bot commented May 22, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 28, 2024
@mrserb
Copy link
Member Author

mrserb commented May 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit f867d97.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • 3663b2d: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • b96b4f6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • 5a659b7: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • e32e05b: 8329840: Fix ZPhysicalMemorySegment::_end type
  • a3e51ec: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • ae8dae9: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@mrserb Pushed as commit f867d97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant