Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322790: RISC-V: Tune costs for shuffles with no conversion #22

Conversation

Ilyagavrilin
Copy link

@Ilyagavrilin Ilyagavrilin commented Jan 12, 2024

Hi all, I would like to backport JDK-8322790 to jdk22u in order to improve performance for methods operating with integer representations of floating point values.
Patch applies clean.


Progress

  • JDK-8322790 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322790: RISC-V: Tune costs for shuffles with no conversion (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk22u.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/22.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

👋 Welcome back igavrilin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2acb5bd9924511b58b0e57ea9eb6c2dee9fd3ee8 8322790: RISC-V: Tune costs for shuffles with no conversion Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

⚠️ @Ilyagavrilin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2024

Webrevs

@Ilyagavrilin
Copy link
Author

/approval request I would like to backport this change into jdk22u; Applies clean, low risk, RISC-V only change, only insertion costs changed; Improves performance for java methods that use floating point<->integer shuffles with no conversion

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@Ilyagavrilin
8322790: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@Ilyagavrilin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322790: RISC-V: Tune costs for shuffles with no conversion

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 8ff288f: 8318158: RISC-V: implement roundD/roundF intrinsics
  • e27e599: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
  • a1f0a3c: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • ed269bf: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 7b32b94: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 879d36e: 8323331: fix typo hpage_pdm_size
  • dfce95a: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 18, 2024
@Ilyagavrilin
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 19, 2024
@openjdk
Copy link

openjdk bot commented Jan 19, 2024

@Ilyagavrilin
Your change (at version ed4c988) is now ready to be sponsored by a Committer.

@VladimirKempik
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 19, 2024

Going to push as commit bbbc0ea.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8ff288f: 8318158: RISC-V: implement roundD/roundF intrinsics
  • e27e599: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
  • a1f0a3c: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • ed269bf: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 7b32b94: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 879d36e: 8323331: fix typo hpage_pdm_size
  • dfce95a: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2024
@openjdk openjdk bot closed this Jan 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 19, 2024
@openjdk
Copy link

openjdk bot commented Jan 19, 2024

@VladimirKempik @Ilyagavrilin Pushed as commit bbbc0ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants