8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml

[fitzsim]

I would like to have this patch applied to jdk22u, and then backport it to 21, 17, 11 and 8. This will eliminate an issue reported by rpminspect.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8332174 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml (Bug - P4 - Requested) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/223/head:pull/223
$ git checkout pull/223

Update a local copy of the PR:
$ git checkout pull/223
$ git pull https://git.openjdk.org/jdk22u.git pull/223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 223

View PR using the GUI difftool:
$ git pr show -t 223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/223.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (4910826e)

[gnu-andrew]

I've confirmed this matches the part of the upstream patch which alters the code under common.

The PR title needs to be adjusted to match the title of the bug (or vice versa)

I think this may be too late for 22 (final release in July) but we can ask for approval here and open a PR with the same change to 21u while we wait on that.

[openjdk]

⚠️ @fitzsim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[fitzsim]

/approval request

[fitzsim]

The PR title needs to be adjusted to match the title of the bug

Done.

I think this may be too late for 22 (final release in July) but we can ask for approval here

Done.

and open a PR with the same change to 21u while we wait on that.

I will now attempt to issue the appropriate backport SKARA command.

[openjdk]

@fitzsim
8332174: The approval request has been created successfully.

[fitzsim]

/backport jdk21u-dev

[openjdk]

@fitzsim To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

[gnu-andrew]

/backport jdk21u-dev

This is to be run on commits by a Committer. I can do it on your behalf once the 22u patch is in, but it's probably easier to just apply the patch yourself.

[fitzsim]

I am not sure if this is too late for 22u; just in case, I also, per @gnu-andrew's suggestion, I also filed a 21u backport: openjdk/jdk21u-dev#732 with the intent of this patch going to 17 and 11 also eventually.

[bridgekeeper]

@fitzsim This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!