-
Notifications
You must be signed in to change notification settings - Fork 59
8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition #224
8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition #224
Conversation
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
Going to push as commit 66cdc14.
Your commit was automatically rebased without conflicts. |
@dholmes-ora Pushed as commit 66cdc14. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial backport to fix Windows 32-bit build issue.
Thanks.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/224/head:pull/224
$ git checkout pull/224
Update a local copy of the PR:
$ git checkout pull/224
$ git pull https://git.openjdk.org/jdk22u.git pull/224/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 224
View PR using the GUI difftool:
$ git pr show -t 224
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/224.diff
Webrev
Link to Webrev Comment