Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331714: Make OopMapCache installation lock-free #225

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented May 28, 2024

Clean backport to improve internal locking. Makes future backports clean.

Additional testing:

  • GHA
  • Linux x86_64 fastdebug hotspot_gc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331714 needs maintainer approval

Issue

  • JDK-8331714: Make OopMapCache installation lock-free (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk22u.git pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/225.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331714: Make OopMapCache installation lock-free

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • ca393c8: 8330576: ZYoungCompactionLimit should have range check
  • 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
  • 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • f867d97: 8331746: Create a test to verify that the cmm id is not ignored
  • 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • 3663b2d: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • b96b4f6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a2584a8341b2dc9c102abd373a890b2108d3f57e 8331714: Make OopMapCache installation lock-free May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 28, 2024
@shipilev shipilev force-pushed the JDK-8331714-oopmapcache-lock-free branch from c26d958 to e187699 Compare May 28, 2024 08:43
@openjdk
Copy link

openjdk bot commented May 28, 2024

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve internal locking. Also makes future backports clean by avoiding lock ranking problems. The patch was in mainline for 3 weeks without bugtail. The change is simple, and thus the risk is on the lower side.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@shipilev
8331714: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 28, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2024

Going to push as commit d7d718d.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • ca393c8: 8330576: ZYoungCompactionLimit should have range check
  • 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
  • 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • f867d97: 8331746: Create a test to verify that the cmm id is not ignored
  • 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • 3663b2d: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • b96b4f6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2024
@openjdk openjdk bot closed this May 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

@shipilev Pushed as commit d7d718d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant