8330275: Crash in XMark::follow_array

[ashu-mehra]

Backport of JDK-8330275 to fix crash in ZGC.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8330275 needs maintainer approval

Issue

• JDK-8330275: Crash in XMark::follow_array (Bug - P2 - Approved)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.org/jdk22u.git pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/226.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330275: Crash in XMark::follow_array

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• d7d718d: 8331714: Make OopMapCache installation lock-free
• 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
• ca393c8: 8330576: ZYoungCompactionLimit should have range check
• 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
• 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
• f867d97: 8331746: Create a test to verify that the cmm id is not ignored
• 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @ashu-mehra This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[ashu-mehra]

/approval request This fixes a bug in ZGC that can result in crash when running with huge heap size. It only affects aarch64.

[openjdk]

@ashu-mehra
8330275: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (31d3d42e)

[stefank]

This backports the incorrect comment from the original changeset. Don't you want to update them before pushing?

[ashu-mehra]

This backports the incorrect comment from the original changeset. Don't you want to update them before pushing?

The comments were fixed in separate PR which I am going to backport as well.

[ashu-mehra]

/integrate

[openjdk]

@ashu-mehra
Your change (at version 31d3d42) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit ceba7fc.
Since your change was applied there have been 8 commits pushed to the master branch:

• d7d718d: 8331714: Make OopMapCache installation lock-free
• 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
• ca393c8: 8330576: ZYoungCompactionLimit should have range check
• 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
• 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
• f867d97: 8331746: Create a test to verify that the cmm id is not ignored
• 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @ashu-mehra Pushed as commit ceba7fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.