Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331885: C2: meet between unloaded and speculative types is not symmetric #228

Closed
wants to merge 1 commit into from

Conversation

fmatte1
Copy link

@fmatte1 fmatte1 commented May 29, 2024

8331885: C2: meet between unloaded and speculative types is not symmetric

Reviewed-by: roland, thartmann


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331885 needs maintainer approval

Issue

  • JDK-8331885: C2: meet between unloaded and speculative types is not symmetric (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.org/jdk22u.git pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/228.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2024

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 29, 2024

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331885: C2: meet between unloaded and speculative types is not symmetric

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 108e164: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • 329c7bd: 8325763: Revert properties: vm.opt.x.*
  • 0080e66: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • ceba7fc: 8330275: Crash in XMark::follow_array
  • d7d718d: 8331714: Make OopMapCache installation lock-free
  • 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7652f9811bfddf08650b0c3277012074873deade 8331885: C2: meet between unloaded and speculative types is not symmetric May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 29, 2024
@mlbridge
Copy link

mlbridge bot commented May 29, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 30, 2024
@fmatte1
Copy link
Author

fmatte1 commented Jun 3, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@fmatte1
Your change (at version 5402bff) is now ready to be sponsored by a Committer.

@chhagedorn
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 92e4ba2.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 108e164: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • 329c7bd: 8325763: Revert properties: vm.opt.x.*
  • 0080e66: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • ceba7fc: 8330275: Crash in XMark::follow_array
  • d7d718d: 8331714: Make OopMapCache installation lock-free
  • 91a2e75: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@chhagedorn @fmatte1 Pushed as commit 92e4ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants