-
Notifications
You must be signed in to change notification settings - Fork 57
8333093: Incorrect comment in zAddress_aarch64.cpp #231
8333093: Incorrect comment in zAddress_aarch64.cpp #231
Conversation
👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into |
@ashu-mehra This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Backporting this patch to keep the comments in sync with mainline. Patch applies cleanly. Only comments are updated, so its a no risk change. |
@ashu-mehra |
/integrate |
@ashu-mehra |
/sponsor |
Going to push as commit 108e164.
Your commit was automatically rebased without conflicts. |
@shipilev @ashu-mehra Pushed as commit 108e164. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 51ae08f7 from the openjdk/jdk repository.
The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson.
It is a trivial change to fix the comments.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/231/head:pull/231
$ git checkout pull/231
Update a local copy of the PR:
$ git checkout pull/231
$ git pull https://git.openjdk.org/jdk22u.git pull/231/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 231
View PR using the GUI difftool:
$ git pr show -t 231
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/231.diff
Webrev
Link to Webrev Comment