Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8333093: Incorrect comment in zAddress_aarch64.cpp #231

Closed

Conversation

ashu-mehra
Copy link

@ashu-mehra ashu-mehra commented May 30, 2024

Hi all,

This pull request contains a backport of commit 51ae08f7 from the openjdk/jdk repository.

The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson.

It is a trivial change to fix the comments.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333093 needs maintainer approval

Issue

  • JDK-8333093: Incorrect comment in zAddress_aarch64.cpp (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/231/head:pull/231
$ git checkout pull/231

Update a local copy of the PR:
$ git checkout pull/231
$ git pull https://git.openjdk.org/jdk22u.git pull/231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 231

View PR using the GUI difftool:
$ git pr show -t 231

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/231.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2024

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2024

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333093: Incorrect comment in zAddress_aarch64.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 51ae08f72b879bc611177ea643cd88e36185d9e8 8333093: Incorrect comment in zAddress_aarch64.cpp May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 30, 2024

⚠️ @ashu-mehra This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2024
@mlbridge
Copy link

mlbridge bot commented May 30, 2024

Webrevs

@ashu-mehra
Copy link
Author

/approval request Backporting this patch to keep the comments in sync with mainline. Patch applies cleanly. Only comments are updated, so its a no risk change.

@openjdk
Copy link

openjdk bot commented May 30, 2024

@ashu-mehra
8333093: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 30, 2024
@ashu-mehra
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

@ashu-mehra
Your change (at version cd2f1f1) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Jun 3, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 108e164.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 329c7bd: 8325763: Revert properties: vm.opt.x.*
  • 0080e66: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@shipilev @ashu-mehra Pushed as commit 108e164.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants