Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform #24

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Jan 16, 2024

Hi! I would like to backport JDK-8321972 to jdk22u.
This patch fixes failure of runtime/Unsafe/InternalErrorTest.java after JDK-8320886 for RISC-V platform, that was backported to jdk22 by JDK-8321919.
The original patch applies cleanly. It's related only to RISC-V. No risks for other platforms.
I reproduced this issue on StarFive VisionFive2 board. After appling this patch runtime/Unsafe/InternalErrorTest.java passes.
tier1 tests passed for RISC-V platform.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321972 needs maintainer approval

Issue

  • JDK-8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk22u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2024

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8768ae08dbee9c3e1ed01934142c03ffad5f349 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

This backport pull request has now been updated with issue from the original commit.

@omikhaltsova omikhaltsova marked this pull request as ready for review January 17, 2024 10:18
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

⚠️ @omikhaltsova This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2024
@omikhaltsova
Copy link
Author

/approval request Clean backport, related only to RISC-V platform, that fixed failure of runtime/Unsafe/InternalErrorTest.java after JDK-8320886, being backported to jdk22 by JDK-8321919. tier1 tests passed.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@omikhaltsova
8321972: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@omikhaltsova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • a1f0a3c: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • ed269bf: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 7b32b94: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 879d36e: 8323331: fix typo hpage_pdm_size
  • dfce95a: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • 3257d9d: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 18, 2024
@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

Going to push as commit e27e599.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a1f0a3c: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • ed269bf: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 7b32b94: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 879d36e: 8323331: fix typo hpage_pdm_size
  • dfce95a: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • 3257d9d: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2024
@openjdk openjdk bot closed this Jan 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@omikhaltsova Pushed as commit e27e599.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant