Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 #240

Closed
wants to merge 1 commit into from

Conversation

raviniitw2012
Copy link

@raviniitw2012 raviniitw2012 commented Jun 4, 2024

Hi,

Please review the update to open/src/java.base/share/legal/zlib.md to update the file from zlib 1.3 to zlib 1.3.1 which was missed as part of the PR for JDK-8324632

Thanks,
Ravi


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326351 needs maintainer approval

Issue

  • JDK-8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 (Bug - P4 - Approved) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jdk22u.git pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/240.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2024

👋 Welcome back rreddy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

@raviniitw2012 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Jun 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 4, 2024
@raviniitw2012
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

@raviniitw2012
Your change (at version 73e26a8) is now ready to be sponsored by a Committer.

@LanceAndersen
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

Going to push as commit e1b620e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 4, 2024
@openjdk openjdk bot closed this Jun 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

@LanceAndersen @raviniitw2012 Pushed as commit e1b620e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants