Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

8333477: Delete extra empty spaces in Makefiles #246

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 8, 2024

Hi all,
This is clean backport to delete several extra trailing whitespaces and extra trailing lines in several Makefiles. It's trivial fix, no risk.
The commit being backported was authored by SendaoYan on 7 Jun 2024 and was reviewed by Erik Joelsson, Christian Hagedorn, Chen Liang and Julian Waters.

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333477 needs maintainer approval

Issue

  • JDK-8333477: Delete extra empty spaces in Makefiles (Bug - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.org/jdk22u.git pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/246.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d130d2f4f46d37a2b924343de19d012c129b0a55 8333477: Delete extra empty spaces in Makefiles Jun 8, 2024
@openjdk
Copy link

openjdk bot commented Jun 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to delete several extra trailing whitespaces and extra trailing lines in several Makefiles. It's trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Jun 8, 2024

@sendaoYan
8333477: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 8, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

I think jdk22u not needed backport any longer

@sendaoYan sendaoYan closed this Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant