Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8318696: Do not use LFS64 symbols on Linux #26

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 22, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318696 needs maintainer approval

Issue

  • JDK-8318696: Do not use LFS64 symbols on Linux (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk22u.git pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/26.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f4d08ccf80812d4f26a148fac6bf99b96672a63f 8318696: Do not use LFS64 symbols on Linux Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 22, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318696: Do not use LFS64 symbols on Linux

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • e995a73: Merge
  • 23301d5: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • 5a77c29: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing
  • 79c3d47: 8324082: more monitoring test timeout adjustments
  • 73c77d9: 8324074: increase timeout for jvmci test TestResolvedJavaMethod.java
  • b178894: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
  • 9c7cab5: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
  • b5ed8cc: 8322799: Test JPKG003-013: ServiceTest fails because the user cannot uninstall the "servicetest" package on OEL 9.2 x64 and OEL 9.2 64-bit Arm (aarch64)
  • f9f7a27: 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader
  • 60c68a1: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • ... and 52 more: https://git.openjdk.org/jdk22u/compare/160f65086c991d28448aa62f44f31b73f2d8d815...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 23, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

Going to push as commit 72c6ad1.
Since your change was applied there have been 62 commits pushed to the master branch:

  • e995a73: Merge
  • 23301d5: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • 5a77c29: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing
  • 79c3d47: 8324082: more monitoring test timeout adjustments
  • 73c77d9: 8324074: increase timeout for jvmci test TestResolvedJavaMethod.java
  • b178894: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
  • 9c7cab5: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs
  • b5ed8cc: 8322799: Test JPKG003-013: ServiceTest fails because the user cannot uninstall the "servicetest" package on OEL 9.2 x64 and OEL 9.2 64-bit Arm (aarch64)
  • f9f7a27: 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader
  • 60c68a1: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • ... and 52 more: https://git.openjdk.org/jdk22u/compare/160f65086c991d28448aa62f44f31b73f2d8d815...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2024
@openjdk openjdk bot closed this Jan 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@MBaesken Pushed as commit 72c6ad1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants