Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case #29

Closed

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Jan 25, 2024

Hi all,

This pull request contains a backport of commit 22642ff0 from the openjdk/jdk repository.

The commit being backported was authored by Joachim Kern on 17 Jan 2024 and was reviewed by Matthias Baesken and Alex Menkov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319382 needs maintainer approval

Issue

  • JDK-8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jdk22u.git pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/29.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 22642ff0aac71eceb71f6a9eebb2988a9bd5f091 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@JoKern65
Copy link
Author

/approval JDK-8319382 request No risk clean backport

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@JoKern65
JDK-8319382: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@JoKern65 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@JoKern65
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@JoKern65
Your change (at version d31a6d6) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit 2e91b4e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@MBaesken @JoKern65 Pushed as commit 2e91b4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants