Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll #3

Closed

Conversation

fthevenet
Copy link
Member

@fthevenet fthevenet commented Dec 18, 2023

Hi all,

This pull request contains a backport of commit 05f95093 from the openjdk/jdk repository.

The commit being backported was authored by Frederic Thevenet on 8 Dec 2023 and was reviewed by Erik Joelsson and Magnus Ihse Bursie.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321374 needs maintainer approval

Issue

  • JDK-8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk22u.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/3.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 05f950934ee720c82e9b62dd8d31e13bab7775da 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

This backport pull request has now been updated with issue from the original commit.

@fthevenet
Copy link
Member Author

NB: Tier1 test com/sun/crypto/provider/Cipher/AEAD/AEADBufferTest JVM crash on linux-86 is unrelated to this change.

@openjdk openjdk bot added the approval label Dec 18, 2023
@fthevenet fthevenet marked this pull request as ready for review December 18, 2023 16:09
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @fthevenet This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@fthevenet This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 512cd87: 8322417: Console read line with zero out should zero out when throwing exception
  • 75f52ea: Merge
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
  • 57d97b5: 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are incorrect
  • 6b46c77: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • d7b592a: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • d62249a: 8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion
  • 41b7296: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized
  • a55e18b: 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec contains a copy-paste error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 8, 2024
@fthevenet
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@fthevenet
Your change (at version dc5ceea) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 085dccd.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 07df9e3: 8322725: (tz) Update Timezone Data to 2023d
  • beb35a8: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
  • 136180b: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 512cd87: 8322417: Console read line with zero out should zero out when throwing exception
  • 75f52ea: Merge
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
  • 57d97b5: 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are incorrect
  • 6b46c77: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • d7b592a: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • ... and 3 more: https://git.openjdk.org/jdk22u/compare/84d716a2671845058770ee03c97497d7a711fa92...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@jerboaa @fthevenet Pushed as commit 085dccd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants