8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above)

[lahodaj]

Hi all,

This pull request contains a backport of commit c9cacfb2 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 22 Jan 2024 and was reviewed by Vicente Romero.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323657 needs maintainer approval

Issue

• JDK-8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above) (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/jdk22u.git pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/30.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lahodaj This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (2c66c0f9)

[lahodaj]

/approval request This a fix for a bug where javac optimizes too much, and produces code with incorrect semantics in very rare cases. The fix should be fairly safe, as it only ensures the optimization is disabled unless it is provably correct. Standard javac testing will be done. Thanks!

[openjdk]

@lahodaj
8323657: The approval request has been created successfully.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dfc86f9: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
• 251938a: 8324041: ModuleOption.java failed with update release versioning scheme
• 2e91b4e: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
• af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
• f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
• 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 756cab8.
Since your change was applied there have been 21 commits pushed to the master branch:

• ce8d1c9: 8320890: [AIX] Find a better way to mimic dl handle equality
• a8ac346: Merge
• d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
• 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
• ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
• bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
• d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
• 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
• 4338cb3: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
• ... and 11 more: https://git.openjdk.org/jdk22u/compare/72c6ad18bb139fe978253438eac23d6bf4fdf589...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 756cab8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.