Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint #31

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jan 25, 2024

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321815 needs maintainer approval

Issue

  • JDK-8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/31/head:pull/31
$ git checkout pull/31

Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.org/jdk22u.git pull/31/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31

View PR using the GUI difftool:
$ git pr show -t 31

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/31.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 808a03927c153581cbece93a4f5a4f8242b61ef5 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@earthling-amzn
Copy link
Author

/approval request Clean backport. This change reduces work on the safepoint. We've tested this with Dacapo, Extremem, Heapothesys, SpecJBB2015 and SpecJVM2008.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@earthling-amzn
8321815: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 251938a: 8324041: ModuleOption.java failed with update release versioning scheme
  • 2e91b4e: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@earthling-amzn
Your change (at version 889368a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit dfc86f9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 251938a: 8324041: ModuleOption.java failed with update release versioning scheme
  • 2e91b4e: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@shipilev @earthling-amzn Pushed as commit dfc86f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants