Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321489: Update LCMS to 2.16 #32

Closed

Conversation

alisenchung
Copy link

@alisenchung alisenchung commented Jan 25, 2024

Backport of dc7d3b182d226253ca246dd854c85c4dd964f10e


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321489 needs maintainer approval

Issue

  • JDK-8321489: Update LCMS to 2.16 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.org/jdk22u.git pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/32.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@prrace
Copy link

prrace commented Jan 25, 2024

"Issue of type Backport is not allowed for integrations"

I think this is because you used the backport ID in the PR
You need to use the main bug ID and skara will create / use the backport ID when integrating.

Actually it doesn't look to me like you did this as a backport at all ..

@kevinrushforth
Copy link
Member

@alisenchung The problem is that you manually edited the title, when the one Skara suggested is the one you need to use. To fix this, edit the title to use the one Skara suggested:

Backport dc7d3b182d226253ca246dd854c85c4dd964f10e

@alisenchung alisenchung changed the title 8324740: Update LCMS to 2.16 Backport of dc7d3b182d226253ca246dd854c85c4dd964f10e Jan 25, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 25, 2024
@alisenchung alisenchung changed the title Backport of dc7d3b182d226253ca246dd854c85c4dd964f10e Backport dc7d3b182d226253ca246dd854c85c4dd964f10e Jan 25, 2024
@openjdk openjdk bot changed the title Backport dc7d3b182d226253ca246dd854c85c4dd964f10e 8321489: Update LCMS to 2.16 Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

⚠️ @alisenchung This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024
@alisenchung
Copy link
Author

/integrate

@alisenchung
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@alisenchung This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@alisenchung usage: /approval [<id>] (request|cancel) [<text>]

@GoeLin
Copy link
Member

GoeLin commented Jan 26, 2024

Hi,
thanks for picking this up. It need to be backported to 21, 17 and 11.
Maybe you want to have a look at the instruction in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
We ususally backport these changes to the same release as Oracle does. And as they did not do so yet, it's maybe a bit early for this.

@kevinrushforth
Copy link
Member

@GoeLin Alisen works for Oracle and will be doing the backports to the Oracle releases soon. You might look to someone else in the OpenJDK community to pick this up for OpenJDK 21u, 17u, and 11u

@alisenchung
Copy link
Author

/approval request upgrading lcms

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@alisenchung
8321489: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 26, 2024
@GoeLin
Copy link
Member

GoeLin commented Jan 29, 2024

@alisenchung @kevinrushforg ah, you are right, it's 22 not 21 ... but looking at the doc might be helpful anyways.

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321489: Update LCMS to 2.16

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • dfc86f9: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
  • 251938a: 8324041: ModuleOption.java failed with update release versioning scheme
  • 2e91b4e: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 1, 2024
@alisenchung
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@alisenchung
Your change (at version 8cb189a) is now ready to be sponsored by a Committer.

@azuev-java
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

Going to push as commit d0d5064.
Since your change was applied there have been 6 commits pushed to the master branch:

  • dfc86f9: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
  • 251938a: 8324041: ModuleOption.java failed with update release versioning scheme
  • 2e91b4e: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • af59286: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • f5dc3ea: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 291bd16: 8324659: GHA: Generic jtreg errors are not reported

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2024
@openjdk openjdk bot closed this Feb 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@azuev-java @alisenchung Pushed as commit d0d5064.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
5 participants