-
Notifications
You must be signed in to change notification settings - Fork 58
8321489: Update LCMS to 2.16 #32
8321489: Update LCMS to 2.16 #32
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
I think this is because you used the backport ID in the PR Actually it doesn't look to me like you did this as a backport at all .. |
@alisenchung The problem is that you manually edited the title, when the one Skara suggested is the one you need to use. To fix this, edit the title to use the one Skara suggested:
|
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
/approval |
@alisenchung This pull request has not yet been marked as ready for integration. |
@alisenchung usage: |
Hi, |
@GoeLin Alisen works for Oracle and will be doing the backports to the Oracle releases soon. You might look to someone else in the OpenJDK community to pick this up for OpenJDK 21u, 17u, and 11u |
/approval request upgrading lcms |
@alisenchung |
@alisenchung @kevinrushforg ah, you are right, it's 22 not 21 ... but looking at the doc might be helpful anyways. |
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@alisenchung |
/sponsor |
Going to push as commit d0d5064.
Your commit was automatically rebased without conflicts. |
@azuev-java @alisenchung Pushed as commit d0d5064. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of dc7d3b182d226253ca246dd854c85c4dd964f10e
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/32/head:pull/32
$ git checkout pull/32
Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.org/jdk22u.git pull/32/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32
View PR using the GUI difftool:
$ git pr show -t 32
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/32.diff
Webrev
Link to Webrev Comment