Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 #36

Closed

Conversation

tschatzl
Copy link

@tschatzl tschatzl commented Jan 30, 2024

Hi all,

This pull request contains a backport of commit 0d5f5e15 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 29 Jan 2024 and was reviewed by Kim Barrett and Albert Mingkun Yang.

Applied cleanly. Thanks!

Thomas


Progress

  • Change must not contain extraneous whitespace
  • JDK-8322484 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk22u.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/36.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0d5f5e15d43f94a79c6133baecd5af217365d176 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the approval label Feb 6, 2024
@tschatzl tschatzl marked this pull request as ready for review February 8, 2024 13:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • cebe57d: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
  • 648a161: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • d6fc2b1: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 324d7cc: 8327467: Bump version numbers for 22.0.2
  • 882978f: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
  • dd4dc38: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
  • b73c15e: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
  • 78df8c1: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • ... and 50 more: https://git.openjdk.org/jdk22u/compare/251938a8eb20e10958fd8a7ef0bdf2a8ec6a1be9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated approval and removed approval ready Pull request is ready to be integrated labels Feb 29, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 8, 2024
@tschatzl
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit a99aa0e.
Since your change was applied there have been 68 commits pushed to the master branch:

  • 2e5c300: 8320005: Allow loading of shared objects with .a extension on AIX
  • 9b52a00: 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX
  • 244c1d8: 8187759: Background not refreshed when painting over a transparent JFrame
  • b2275aa: 8325730: StringBuilder.toString allocation for the empty String
  • fd11382: 8324834: Use _LARGE_FILES on AIX
  • f510fe8: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 6b307d7: 8327059: os::Linux::print_proc_sys_info add swappiness information
  • f5cfcbb: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • cffdef1: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 6ac9326: 8327391: Add SipHash attribution file
  • ... and 58 more: https://git.openjdk.org/jdk22u/compare/251938a8eb20e10958fd8a7ef0bdf2a8ec6a1be9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@tschatzl Pushed as commit a99aa0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the backport-tschatzl-0d5f5e15 branch March 13, 2024 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant