Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8323637: Capture hotspot replay files in GHA #39

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 1, 2024

Clean backport to improve GHA debugging capabilities.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323637 needs maintainer approval

Issue

  • JDK-8323637: Capture hotspot replay files in GHA (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.org/jdk22u.git pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/39.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c84c0ab52d5e08a693f7ad7d9a4772d8c1eeeaa8 8323637: Capture hotspot replay files in GHA Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2024

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Feb 1, 2024

/approval request Clean backport to improve GHA debugging capabilities. GHA passes.

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@shipilev
8323637: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 2, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323637: Capture hotspot replay files in GHA

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d0d5064: 8321489: Update LCMS to 2.16

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 2, 2024
@shipilev
Copy link
Member Author

shipilev commented Feb 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2024

Going to push as commit 5e3dec2.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 576fc10: 8324937: GHA: Avoid multiple test suites per job
  • d0d5064: 8321489: Update LCMS to 2.16

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2024
@openjdk openjdk bot closed this Feb 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2024
@openjdk
Copy link

openjdk bot commented Feb 2, 2024

@shipilev Pushed as commit 5e3dec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant