Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320890: [AIX] Find a better way to mimic dl handle equality #40

Closed

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Feb 5, 2024

Hi all,

This pull request contains a backport of commit b8ae4a8c from the openjdk/jdk repository.

The commit being backported was authored by Joachim Kern on 11 Jan 2024 and was reviewed by Thomas Stuefe and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320890 needs maintainer approval

Issue

  • JDK-8320890: [AIX] Find a better way to mimic dl handle equality (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.org/jdk22u.git pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/40.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b8ae4a8c0985d1763ac48ba78943d8b992d7be77 8320890: [AIX] Find a better way to mimic dl handle equality Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2024

Webrevs

@JoKern65
Copy link
Author

JoKern65 commented Feb 6, 2024

/approval JDK-8320890 request I backport this to fix the bug on AIX. Clean backport. Test runs on various platforms succeeded. Minor risk as the shared code changes are basically a refactoring, so the risk is limited to AIX.

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@JoKern65
JDK-8320890: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@JoKern65 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320890: [AIX] Find a better way to mimic dl handle equality

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • a8ac346: Merge
  • d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
  • 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
  • ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
  • d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
  • 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
  • 4338cb3: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
  • b7f38fc: 8324688: C2: Disable ReduceAllocationMerges by default
  • ... and 1 more: https://git.openjdk.org/jdk22u/compare/5e3dec25259082d00ff65da6ce02e5b41ce00438...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 8, 2024
@JoKern65
Copy link
Author

JoKern65 commented Feb 8, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@JoKern65
Your change (at version ef4fcfc) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Feb 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

Going to push as commit ce8d1c9.
Since your change was applied there have been 11 commits pushed to the master branch:

  • a8ac346: Merge
  • d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
  • 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
  • ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
  • bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
  • d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
  • ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
  • 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
  • 4338cb3: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
  • b7f38fc: 8324688: C2: Disable ReduceAllocationMerges by default
  • ... and 1 more: https://git.openjdk.org/jdk22u/compare/5e3dec25259082d00ff65da6ce02e5b41ce00438...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 9, 2024
@openjdk openjdk bot closed this Feb 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@GoeLin @JoKern65 Pushed as commit ce8d1c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants