8322159: ThisEscapeAnalyzer crashes for erroneous code

[lahodaj]

Hi all,

This pull request contains a backport of commit 7455b1b5 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 2 Jan 2024 and was reviewed by Vicente Romero.

Thanks!

---

Progress

• JDK-8322159 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322159: ThisEscapeAnalyzer crashes for erroneous code (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/41/head:pull/41
$ git checkout pull/41

Update a local copy of the PR:
$ git checkout pull/41
$ git pull https://git.openjdk.org/jdk22u.git pull/41/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 41

View PR using the GUI difftool:
$ git pr show -t 41

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/41.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lahodaj This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (914630d4)

[lahodaj]

/approval request This patch prevents a javac crash when working with erroneous code. It would be nice to be able to handle erroneous input without crashing. The fix should fairly safe, as it basically only skips some checks when the input is erroneous. Standard javac testing will be done.

[openjdk]

@lahodaj
8322159: The approval request has been created successfully.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322159: ThisEscapeAnalyzer crashes for erroneous code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• a8ac346: Merge
• d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
• 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
• ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
• bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
• d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
• 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
• 4338cb3: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
• b7f38fc: 8324688: C2: Disable ReduceAllocationMerges by default
• ... and 1 more: https://git.openjdk.org/jdk22u/compare/5e3dec25259082d00ff65da6ce02e5b41ce00438...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 1d33855.
Since your change was applied there have been 13 commits pushed to the master branch:

• 756cab8: 8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above)
• ce8d1c9: 8320890: [AIX] Find a better way to mimic dl handle equality
• a8ac346: Merge
• d8dc711: 8324983: Race in CompileBroker::possibly_add_compiler_threads
• 9a4d4ab: 8324041: ModuleOption.java failed with update release versioning scheme
• ac7a3c0: 8322066: Update troff manpages in JDK 22 before RC
• bff5e90: 8319547: Remove EA from the JDK 22 version string with first RC promotion
• d2927cf: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out
• ee4d54c: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
• 306e364: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
• ... and 3 more: https://git.openjdk.org/jdk22u/compare/5e3dec25259082d00ff65da6ce02e5b41ce00438...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 1d33855.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.