Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8314275: Incorrect stepping in switch #47

Closed

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Feb 9, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314275 needs maintainer approval

Issue

  • JDK-8314275: Incorrect stepping in switch (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk22u.git pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/47.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2024

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e3dc6a7a28c4f049eb234c5487fca6c54298aa31 8314275: Incorrect stepping in switch Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

⚠️ @biboudis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 9, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314275: Incorrect stepping in switch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2b247d0: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
  • 83ff84a: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • 6e426ec: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • bc606a0: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 4ab7711: 8324753: [AIX] adjust os_posix after JDK-8318696
  • 06e8a7f: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX
  • ffd0299: 8325150: (tz) Update Timezone Data to 2024a
  • 1d33855: 8322159: ThisEscapeAnalyzer crashes for erroneous code
  • 756cab8: 8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 14, 2024
@biboudis
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@biboudis
Your change (at version 83d2a57) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

Going to push as commit 457526d.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 2b247d0: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
  • 83ff84a: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • 6e426ec: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • bc606a0: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 4ab7711: 8324753: [AIX] adjust os_posix after JDK-8318696
  • 06e8a7f: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX
  • ffd0299: 8325150: (tz) Update Timezone Data to 2024a
  • 1d33855: 8322159: ThisEscapeAnalyzer crashes for erroneous code
  • 756cab8: 8323657: Compilation of snippet results in VerifyError at runtime with --release 9 (and above)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2024
@openjdk openjdk bot closed this Feb 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@vicente-romero-oracle @biboudis Pushed as commit 457526d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants