Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8325203: System.exit(0) kills the launched 3rd party application #49

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 9, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325203 needs maintainer approval

Issue

  • JDK-8325203: System.exit(0) kills the launched 3rd party application (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk22u.git pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/49.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6944537c3ebbbb638479e4c2b90a71ad5869023c 8325203: System.exit(0) kills the launched 3rd party application Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

⚠️ @alexeysemenyukoracle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Feb 9, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2024

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

/approval request

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@alexeysemenyukoracle
8325203: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325203: System.exit(0) kills the launched 3rd party application

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 83ff84a: 8324637: [aix] Implement support for reporting swap space in jdk.management
  • 6e426ec: 8324598: use mem_unit when working with sysinfo memory and swap related information
  • bc606a0: 8323964: runtime/Thread/ThreadCountLimit.java fails intermittently on AIX
  • 4ab7711: 8324753: [AIX] adjust os_posix after JDK-8318696
  • 06e8a7f: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 14, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 14, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@alexeysemenyukoracle
Your change (at version 762e14e) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

Going to push as commit 92e5738.
Since your change was applied there have been 25 commits pushed to the master branch:

  • ff84cce: 8325496: Make TrimNativeHeapInterval a product switch
  • a093d62: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 6edd16d: Merge
  • a44bfa4: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 5c08afe: 8325470: [AIX] use fclose after fopen in read_psinfo
  • baf9a79: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 8fc80fe: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • b6ed6d8: 8326360: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3
  • 7bfe8a2: 8321408: Add Certainly roots R1 and E1
  • b56bba8: 8323675: Race in jdk.javadoc-gendata
  • ... and 15 more: https://git.openjdk.org/jdk22u/compare/ffd0299266dd688c13d23d48cff9acd4e0d56921...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2024
@openjdk openjdk bot closed this Feb 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@shipilev @alexeysemenyukoracle Pushed as commit 92e5738.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sblantipodi
Copy link

sblantipodi commented Mar 21, 2024

@alexeysemenyukoracle I'm sorry if I quote you,
may I ask if this fix has been released with the current JDK 22 release?

@kevinrushforth
Copy link
Member

@alexeysemenyukoracle I'm sorry if I quote you, may I ask if this fix has been released with the current JDK 22 release?

I'm not Alexey, but I can answer this. As can be seen in the JBS issue, this fix was backported to JDK 22.0.1. The release date for 22.0.1 is April 16, 2024.

@sblantipodi
Copy link

thanks Kevin, I really appreciate your work in the Java community. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants