Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 #52

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Feb 13, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325590 needs maintainer approval

Issue

  • JDK-8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jdk22u.git pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/52.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 13d9e8ff38536287b82c54bb63bd2d20f65615dc 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

⚠️ @RogerRiggs This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@RogerRiggs This pull request has not yet been marked as ready for integration.

@RogerRiggs
Copy link
Contributor Author

/approval Backport of fix for bug in java.nio.file.Files.readString(path, charset).

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@RogerRiggs usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added the approval label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 14, 2024
@RogerRiggs
Copy link
Contributor Author

Superseded by #55.

@RogerRiggs RogerRiggs closed this Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants