Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8323675: Race in jdk.javadoc-gendata #53

Closed

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Feb 16, 2024

This backports a fix for an intermittent build issue. We just had this break the build for jdk22 RC. The backport attempt to jdk22 missed the RDP2 deadline, but I think it would be nice to get this into 22u to avoid more random build failures there.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323675 needs maintainer approval

Issue

  • JDK-8323675: Race in jdk.javadoc-gendata (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/53/head:pull/53
$ git checkout pull/53

Update a local copy of the PR:
$ git checkout pull/53
$ git pull https://git.openjdk.org/jdk22u.git pull/53/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 53

View PR using the GUI difftool:
$ git pr show -t 53

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/53.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9049402a1b9394095b04287eef1f2d46c4da60e9 8323675: Race in jdk.javadoc-gendata Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

⚠️ @erikj79 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2024

Webrevs

@erikj79
Copy link
Member Author

erikj79 commented Feb 16, 2024

/approval request Fixes an intermittent build problem. Low risk as the patch has been working fine in 23 for a while now.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@erikj79
8323675: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323675: Race in jdk.javadoc-gendata

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ab431cf: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 32b3998: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 19, 2024
@erikj79
Copy link
Member Author

erikj79 commented Feb 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

Going to push as commit b56bba8.
Since your change was applied there have been 8 commits pushed to the master branch:

  • b6f1041: Merge
  • fe9f050: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 6d9a50e: 8325001: Typo in the javadocs for the Arena::ofShared method
  • 9cc260d: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
  • 1ccd654: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 0aabd55: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • ab431cf: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 32b3998: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2024
@openjdk openjdk bot closed this Feb 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@erikj79 Pushed as commit b56bba8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant