Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout #54

Closed
wants to merge 1 commit into from

Conversation

antbob
Copy link
Contributor

@antbob antbob commented Feb 16, 2024

This is a backport of JDK-8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

It is required for backport of JDK-8054022 / openjdk/jdk11u-dev#2523 so i'm trying to bring it back all the way to 11u-dev.

The patch applies clean.

Testing: x86_64 build, affected test


Progress

  • Change must not contain extraneous whitespace
  • JDK-8314164 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.org/jdk22u.git pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/54.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

👋 Welcome back antbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fbaaac63d4ae8d7cc0ec02ab4b5a934824d1fec1 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

⚠️ @antbob This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2024

Webrevs

@antbob
Copy link
Contributor Author

antbob commented Feb 16, 2024

/approval request This is required for backport of JDK-8054022 / openjdk/jdk11u-dev#2523 so i'm trying to bring it back all the way to 11u-dev. The patch applies clean. Testing: x86_64 build, affected test.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@antbob
8314164: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

⚠️ @antbob the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8314164
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@antbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ab431cf: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 32b3998: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 19, 2024
@antbob
Copy link
Contributor Author

antbob commented Feb 19, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 19, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@antbob
Your change (at version fd08003) is now ready to be sponsored by a Committer.

@tstuefe
Copy link
Member

tstuefe commented Feb 19, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

Going to push as commit 0aabd55.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ab431cf: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 32b3998: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 19, 2024
@openjdk openjdk bot closed this Feb 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 19, 2024
@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@tstuefe @antbob Pushed as commit 0aabd55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@antbob antbob deleted the backport-8314164 branch February 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants