8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

[jaikiran]

Can I get a review of this PR which proposes to backport https://bugs.openjdk.org/browse/JDK-8325590 to JDK 22u. This is a clean backport and supersedes the one that Roger opened a few days back #52. Roger is away so the other PR hasn't yet been integrated. JDK-8325590, as noted in the JBS issue, has been approved for a 22u backport.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325590 needs maintainer approval

Issue

• JDK-8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 (Bug - P1 - Approved)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/55/head:pull/55
$ git checkout pull/55

Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.org/jdk22u.git pull/55/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 55

View PR using the GUI difftool:
$ git pr show -t 55

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/55.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

Reviewed-by: dfuchs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (2479f71c)

[jaikiran]

/integrate delegate

[openjdk]

@jaikiran Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

[dfuch]

I looked at Roger's PR and this PR and they do look identical to me.
The change len -> caLen is present so that looks good to me.
Maybe @AlanBateman will want to review too since he reviewed the original backport

[jaikiran]

Thank you Daniel and Alan for the reviews.

/integrate

[openjdk]

@jaikiran
Your change (at version 2479f71) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 32b3998.

[openjdk]

@dfuch @jaikiran Pushed as commit 32b3998.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.