Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8321408: Add Certainly roots R1 and E1 #56

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Feb 16, 2024

Clean backport to JDK 22u


Progress

  • JDK-8321408 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321408: Add Certainly roots R1 and E1 (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.org/jdk22u.git pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/56.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f3073db42aa80b3ced47edea8d2e8add874fb70f 8321408: Add Certainly roots R1 and E1 Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2024
@rhalade
Copy link
Member Author

rhalade commented Feb 16, 2024

/approval 8321408 request The fix is to add new root CA certificates. The patch applies cleanly and has good test coverage.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@rhalade
8321408: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 16, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 19, 2024

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321408: Add Certainly roots R1 and E1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 19, 2024
@rhalade
Copy link
Member Author

rhalade commented Feb 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

Going to push as commit 7bfe8a2.
Since your change was applied there have been 7 commits pushed to the master branch:

  • b56bba8: 8323675: Race in jdk.javadoc-gendata
  • b6f1041: Merge
  • fe9f050: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 6d9a50e: 8325001: Typo in the javadocs for the Arena::ofShared method
  • 9cc260d: 8324858: [vectorapi] Bounds checking issues when accessing memory segments
  • 1ccd654: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 0aabd55: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2024
@openjdk openjdk bot closed this Feb 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@rhalade Pushed as commit 7bfe8a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant