Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8326360: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3 #61

Closed
wants to merge 1 commit into from

Conversation

LanceAndersen
Copy link

@LanceAndersen LanceAndersen commented Feb 20, 2024

Please review the updates to open/src/java.base/share/legal/zlib.md to update the file from zlib 1.2.13 to zlib 1.3 which was missed as part of the PR for JDK-8315117


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8326360 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8326360: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.org/jdk22u.git pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/61.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326360: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 21, 2024
@LanceAndersen
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

Going to push as commit b6ed6d8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024
@openjdk openjdk bot closed this Feb 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@LanceAndersen Pushed as commit b6ed6d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants