Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323515: Create test alias "all" for all test roots #65

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 22, 2024

Improves JDK 22u testability by allowing to run all tests at once. Test groups sanity is going to be tested with GHA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324647 needs maintainer approval
  • JDK-8323515 needs maintainer approval

Issues

  • JDK-8323515: Create test alias "all" for all test roots (Enhancement - P4 - Approved)
  • JDK-8324647: Invalid test group of lib-test after JDK-8323515 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/65/head:pull/65
$ git checkout pull/65

Update a local copy of the PR:
$ git checkout pull/65
$ git pull https://git.openjdk.org/jdk22u.git pull/65/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 65

View PR using the GUI difftool:
$ git pr show -t 65

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/65.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shipilev
Copy link
Member Author

This is chain of two commits, but both commits are clean.

/clean

@openjdk openjdk bot changed the title Backport 8b9bf758801400e4491326cd4c90fc117b9d97e1 8323515: Create test alias "all" for all test roots Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review clean labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Improves JDK 22u testability by allowing to run all tests at once. Test groups sanity is going to be tested with GHA.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
8323515: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 22, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2024

Webrevs

@shipilev
Copy link
Member Author

/issue add JDK-8324647

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
Adding additional issue to issue list: 8324647: Invalid test group of lib-test after JDK-8323515.

@shipilev
Copy link
Member Author

shipilev commented Feb 22, 2024

/approval JDK-8323515 request Improves JDK 22u testability by allowing to run all tests at once. Applies cleanly. Test groups sanity is tested with GHA. Requires JDK-8324647 as the followup.

/approval JDK-8324647 request Follow-up fix for JDK-8323515.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
JDK-8323515: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
JDK-8324647: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323515: Create test alias "all" for all test roots
8324647: Invalid test group of lib-test after JDK-8323515

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a44bfa4: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 5c08afe: 8325470: [AIX] use fclose after fopen in read_psinfo
  • baf9a79: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 8fc80fe: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 27, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

Going to push as commit 79ba08c.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 92e5738: 8325203: System.exit(0) kills the launched 3rd party application
  • ff84cce: 8325496: Make TrimNativeHeapInterval a product switch
  • a093d62: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 6edd16d: Merge
  • a44bfa4: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 5c08afe: 8325470: [AIX] use fclose after fopen in read_psinfo
  • baf9a79: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 8fc80fe: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2024
@openjdk openjdk bot closed this Feb 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@shipilev Pushed as commit 79ba08c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant