-
Notifications
You must be signed in to change notification settings - Fork 57
8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations #67
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This hardens the awt debug build against JNI warnings during assertions. The risk is low as only debug & test code is affected. |
@RealCLanger |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit a44bfa4.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit a44bfa4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8323664, commit 99c9ae12 from the openjdk/jdk repository.
The commit being backported was authored by Christoph Langer on 15 Feb 2024 and was reviewed by Phil Race, Matthias Baesken and Alexey Ivanov.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/67/head:pull/67
$ git checkout pull/67
Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.org/jdk22u.git pull/67/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 67
View PR using the GUI difftool:
$ git pr show -t 67
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/67.diff
Webrev
Link to Webrev Comment