8322417: Console read line with zero out should zero out when throwing exception

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8322417, commit 2f917bff from the openjdk/jdk repository.

The commit being backported was authored by Goetz Lindenmaier on 20 Dec 2023 and was reviewed by Matthias Baesken, Thomas Stuefe and Naoto Sato.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8322772 needs maintainer approval
• JDK-8322417 needs maintainer approval

Issues

• JDK-8322417: Console read line with zero out should zero out when throwing exception (Bug - P4 - Approved)
• JDK-8322772: Clean up code after JDK-8322417 (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.org/jdk22u.git pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/7.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1c0ca361)
• 00: Full (16fe99db)

[RealCLanger]

/approval request Requesting this backport to clear out data in another possible path in JConsole password handling. Testing: SAP nightlies, GHA.

[openjdk]

@RealCLanger
8322417: The approval request has been created successfully.

[RealCLanger]

/issue add 8322772

[openjdk]

@RealCLanger
Adding additional issue to issue list: 8322772: Clean up code after JDK-8322417.

[RealCLanger]

/approval JDK-8322772 request Requesting as inline part of the backport of JDK-8322417.

[openjdk]

@RealCLanger
JDK-8322772: The approval request has been created successfully.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322417: Console read line with zero out should zero out when throwing exception
8322772: Clean up code after JDK-8322417

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 512cd87.

[openjdk]

@RealCLanger Pushed as commit 512cd87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.